Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use empty struct instead of bool for map values #19457

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: use empty struct instead of bool for map values #19457

wants to merge 2 commits into from
+4 −4

Conversation

1911860538
Copy link

No description provided.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 1911860538
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @1911860538. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.88%. Comparing base (49f34c9) to head (5fbba89).

Files with missing lines Patch % Lines
server/storage/util.go 75.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/util.go 81.57% <75.00%> (ø)

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19457      +/-   ##
==========================================
- Coverage   68.92%   68.88%   -0.04%     
==========================================
  Files         420      420              
  Lines       35753    35753              
==========================================
- Hits        24642    24628      -14     
- Misses       9690     9699       +9     
- Partials     1421     1426       +5

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f34c9...5fbba89. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1911860538 @k8s-ci-robot